MAINT: clean up some macros in scalarapi.c #15386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed about the brackets, could probably remove it from the |
3abb51b to
28c3b21
Compare
|
Sloppy of me, thanks for catching the pointer thing. Updated. |
eric-wieser
commented
Jan 22, 2020
Using a macro in an if without parens is just weird. Also, simplies macros to use existing macros, and add comments to make clear why `Void` is special.
28c3b21 to
b7068dd
Compare
|
LGTM, just waiting for tests, thanks. |
|
Glad I got there in the end - a little bit more work than I was intending to put into a throwaway patch that distracted me from #15385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a macro in an if without parens is just weird.
Also, the void cases here match the pattern, so do not need special-casing.