BUG: Cygwin Workaround for #14787 on affected platforms #17548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commands replaces obsolete (no longer used anywhere AFICT check_compiler_gcc4 with some more general utilities for checking GCC version
… flags when building the numpy.core._multiarray_umath module This adds the extra compile args to the extension needed to work around the bug but only in the known case where the bug is relevant.
mattip
reviewed
Oct 14, 2020
|
If you are using non-msvc and have a second, could you check that gh-17547 builds/runs for you? |
|
Thanks! |
|
Will check #17547 once I'm back on my Windows machine. |
DWesl
added a commit
to DWesl/numpy
that referenced
this pull request
Oct 27, 2020
This reverts commit d9c21bb. Replaced by numpy#17548.
DWesl
added a commit
to DWesl/numpy
that referenced
this pull request
Oct 27, 2020
This reverts commit 92eaff3. Replaced by numpy#17548.
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Dec 31, 2020
This reverts commit d9c21bb. Replaced by numpy#17548.
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Dec 31, 2020
This reverts commit 92eaff3. Replaced by numpy#17548.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed the issue for me on Cygwin with GCC 7.4.0 by adding the compiler flags necessary to work around the issue as described in #14787.
Might also help with #16246.