-
-
Notifications
You must be signed in to change notification settings - Fork 11k
SIMD, BUG: fix reuses the previous values during the fallback to libc #17763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, not fluid with SIMD, but this looks good to me! Also good you noticed the sincos issue. I guess the last test could do an exact check, but probably no good reason either.
ping @r-devulap |
Wouldn't preventing the store from writing to these elements be a simpler and efficient fix? That is, change |
… access of glibc fallback
yes, sure it will fix it but I just tried to take advantage and slightly improve performance. I removed |
actually using |
Thanks Sayed. I expect we will be tweaking the SIMD code going forward once it is all working. |
Very surprising to see any measurable difference with just the use of |
closes #17761