BUG: numpy.putmask respecting writeable flag #17873
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other path must leak, since dtype registration is permanent (at least I think so).
The readonly flag was not being set and untested. Also the request for a readonly buffer incorrectly did not set an error.
BUG: Fix buffer readflag errors and small leaks
Bumps [hypothesis](https://github.com/HypothesisWorks/hypothesis) from 5.41.3 to 5.41.4. - [Release notes](https://github.com/HypothesisWorks/hypothesis/releases) - [Commits](HypothesisWorks/hypothesis@hypothesis-python-5.41.3...hypothesis-python-5.41.4) Signed-off-by: dependabot-preview[bot] <[email protected]>
`openblas64_-v0.3.10-win_amd64-gcc_7_1_0.zip` is already given in line 57
MAINT: Remove duplicate dictionary entry
seberg
reviewed
Nov 30, 2020
numpy/core/tests/test_multiarray.py
Outdated
| a = np.arange(12) | ||
| a.setflags(write = False) | ||
|
|
||
| with pytest.raises(Exception) as e_info: |
There was a problem hiding this comment.
It would be nicer if you make this specific, i.e. not Exception but what ever it is (probably a TypeError). You also do not use e_info, so just remove it. If you want to be precise, you can add match="putmask: output array" which will check the error message as well.
|
It seems that I messed up the commit history here. I think it may have been because I:
Don't know how to fix it, so I've opened up a new PR in a new branch with the exact same thing as this one: #17884. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing issue #17871.