BUG: Promotion between strings and objects was assymetric #18152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After an unrelated fix, the logic for string and object promotion was incorrect briefly, this fixes it to be correct (symmetric). Before, string and unicode would return that `string.__common_dtype(object)` is in fact `string`, which is of course incorrect. (since `object.__common_dtype__(other)` always returns `object` this depended on the order, and the NumPy tests apparently did only test the opposite direction (or nothing).
seberg
commented
Jan 11, 2021
| @@ -400,9 +400,10 @@ default_builtin_common_dtype(PyArray_DTypeMeta *cls, PyArray_DTypeMeta *other) | |||
| static PyArray_DTypeMeta * | |||
| string_unicode_common_dtype(PyArray_DTypeMeta *cls, PyArray_DTypeMeta *other) | |||
| { | |||
| assert(cls->type_num < NPY_NTYPES); | |||
| assert(cls->type_num < NPY_NTYPES && cls != other); | |||
There was a problem hiding this comment.
I am currently guaranteeing this, if that would change UNICODE+UNICODE would misbehave (but that would also lead to very loud errors all over the place).
|
Hmmm, test failure in: because |
|
I have been seeing the nm.exe failure about once a week or so. |
|
Thanks Sebastian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an unrelated fix, the logic for string and object promotion
was incorrect briefly, this fixes it to be correct (symmetric).
Before, string and unicode would return that
string.__common_dtype(object)is in factstring, which is ofcourse incorrect. (since
object.__common_dtype__(other)alwaysreturns
objectthis depended on the order, and the NumPy testsapparently did only test the opposite direction (or nothing).