ENH: Add a typing protocol for representing nested sequences - #19894
Merged
Conversation
BvB93
commented
Sep 19, 2021
| _SupportsDType[dtype[_SCT]], | ||
| ] | ||
| _ArrayLike = _NestedSequence[_SupportsArray[dtype[_SCT]]] | ||
| _ArrayLike = _FiniteNestedSequence[_SupportsArray[dtype[_SCT]]] |
Member
Author
There was a problem hiding this comment.
This is used with typevars in def func(a: _ArrayLike[_T]) -> NDArray[_T]: ...-esque expressions, so unfortunately we can't use the new fancy protocol here.
Comment on lines
-2457
to
-2461
| @overload | ||
| def __pow__( | ||
| self: NDArray[Union[bool_, number[Any]]], | ||
| other: _RecursiveSequence, | ||
| ) -> Any: ... |
Member
Author
There was a problem hiding this comment.
Don't need a catchall overload for >4D nested sequences anymore as we can now represent arbitrary levels of nesting.
Member
|
Thanks Bas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a protocol representing a recursive version of
collections.abc.Sequence(going up to arbitrary levels of nesting), thus allowing for the replacement of the older, more verbose union, the latter of which went to 4 levels of nesting.The last time it was attempted to introduce such a protocol (#18155 (comment)) there were still a couple of detrimental mypy bugs related recursive objects, thus preventing its introduction. Fortunately, most of these issues were fixed in python/mypy#9663, though recursive objects in combinations typevars seems to be a combination that's still broken (see below).
Examples