Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: fixed typo of the absolute beginners doc, the result in the example s… #19912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zshwei
Copy link

@zshwei zshwei commented Sep 21, 2021

The result in the example should be [2, 5, 6] instead of [2, 4, 6].
The attached figure also shows result of [2, 5, 6], so it should be a typo.

The result in the example should be [2, 5, 6] instead of [2, 4, 6].
@charris
Copy link
Member

charris commented Sep 21, 2021

The original was correct:

In [1]: data = np.array([[1, 2], [3, 4], [5, 6]])                               

In [2]: data.max(axis=1)                                                        
Out[2]: array([2, 4, 6])

The data used in the images is different. Maybe that was unintentional or the code data should be changed. @melissawm Thoughts?

@charris charris closed this Sep 21, 2021
@zshwei zshwei deleted the fix-typo-of-beginner-doc branch September 22, 2021 01:39
@melissawm
Copy link
Member

Yes - this is something we discussed with @MarsBarLee, we should look into that. Thanks for the ping!

@MarsBarLee
Copy link
Contributor

The image can certainly can be changed! If we modify the original, I just need to find the matching font, which looks like a default font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants