BUG: Reject buffers with suboffsets #20592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not actually support them (and never did). We could support them by copying the data. But right now it seems more important to reject them (while there was a PR to implement it, it has gotten little attention). Test/oiringal PR: Co-authored-by: Alexander Belopolsky <[email protected]>
0f1f028 to
27b5a24
Compare
|
An interesting point is that by erroring here, we do not allow the object to still implement |
|
Does this need a release note? |
|
I lean to no, because if suboffsets is set the buffer data should contain pointers, so what we return is garbage (there is a weird chance that someone sets it, but doesn't use it). |
|
Thanks @seberg |
This was referenced Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not actually support them (and never did). We could support
them by copying the data. But right now it seems more important
to reject them (while there was a PR to implement it, it has gotten
little attention).
Test/oiringal PR:
Co-authored-by: Alexander Belopolsky [email protected]
The PR I was referring to is this one: #7467