-
-
Notifications
You must be signed in to change notification settings - Fork 11k
BLD: Try adding aarch64 wheels [wheel build] #20987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mattip @rgommers I think this is ready for an initial review now. There's still somethings that I have to add(e.g. wheel uploading, and the triggering mechanism present on GHA), but it basically works now. It should be trivial to add, as it would probably just mean refactoring out the bash logic in GHA to a shared file under tools and calling it from both Travis CI and GHA. For wheel uploading, someone needs to add the upload tokens to both staging and nightly under the names |
Isn't this running the build/test twice: once in CIBUILDWHEEL and once in the travis scripts at the end? |
No, I'm pretty sure I overrided the build/test components on the wheel builders. (Because I didn't override the before_install step, it still executes on the wheel builders. Should be harmeless given that building happens in a docker container, but will try to fix in next commit.) |
When I look at the travis-ci run for this PR I see 7 jobs. It is not clear from the ENV which architecture it is, but here is a table. Can you somehow disable runs 3 and 4?
|
7a27734
to
a976d68
Compare
Oh, I think I see what you mean now. |
I think so. Edit: rephrasing to simply agree |
3b6fd72
to
a65f4e6
Compare
Do you want to set up the upload tokens now or leave that for a follow up? I forgot to mention this, but someone also has to set up a cron job too, through the Travis UI to run the weekly builds. (Mostly likely this PR will break the uploading process again for wheels so it might require some tuning but I can't tell until its been merged. Its still likely a good first step as the wheels build successfully) |
Did you try /tools/wheels/upload_wheels.sh on your branch? I wonder why it is echoing the command here |
Done, added NUMPY_NIGHTLY_UPLOAD_TOKEN and NUMPY_STAGING_UPLOAD_TOKEN. These should be available as
Done. |
|
Thanks @lithomas1. |
I manually triggered a build https://app.travis-ci.com/github/numpy/numpy/builds/246680087 by going to the "More Options" pulldown. Hopefully only availalbe to maintainers :). Let's see what happens |
A manual trigger has the line numpy/tools/wheels/upload_wheels.sh Lines 1 to 14 in 8653f04
|
Now the manual trigger does something, but the upload cannot find the wheel
|
Wheels for aarch64 are uploading! https://anaconda.org/scipy-wheels-nightly/numpy/files |
Nice. Thanks a bunch for fixing the typos I made. |
No description provided.