Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Add changelog for masked_invalid change. #22406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Conversation

cmarmo
Copy link
Contributor

@cmarmo cmarmo commented Oct 8, 2022

This pull request add the changelog for #22046.

@cmarmo cmarmo changed the title DOC Add changelog for masked_invalid change. DOC: Add changelog for masked_invalid change. Oct 10, 2022
Copy link
Member

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for the delay. Two "heavy handed" suggestions to put the emphasis on the actual change rather than the reason for it.

But it was good anyway, and I may just push it through (one way or another) if I come across the PR again in the next days.

@seberg
Copy link
Member

seberg commented Oct 14, 2022

Thanks, let's put it in, will get another brief look before the release anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants