Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Added example for get_printoption, recfromtxt and recfromcsv #22558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

DOC: Added example for get_printoption, recfromtxt and recfromcsv #22558

wants to merge 5 commits into from

Conversation

isthatdebbiej
Copy link

No description provided.

@isthatdebbiej
Copy link
Author

Contributed as a part of PyData NYC 2022

@WarrenWeckesser
Copy link
Member

Thanks @isthatdebbiej. The NumPy docstring standard specifies that the Examples section is the last section of the docstring. Also, it should have the same indentation level as the other sections. Finally--really nitpicky, I know--the section name is Examples, not Example (even if there is, in fact, only one example!).

@isthatdebbiej
Copy link
Author

@WarrenWeckesser Thank you! I have updated it.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isthatdebbiej . While looking at this I realized that the keys listed in Returns description are actually out-of-date - we should take this opportunity to either update them, or delete them and refer to the examples section which should be tested and thus always up-to-date.

Comment on lines +2491 to +2494
Examples
--------
np.recfromtxt('data.txt')

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect these were accidentally included on this branch as they seem unrelated to the printoptions example.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added examples for recfromtxt and recfromcsv. Should I create a new PR for that? Or update the PR title?

Copy link
Member

@InessaPawson InessaPawson Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isthatdebbiej In this case, updating the PR title and description will work.
It is recommended though opening a separate PR for each task.

@isthatdebbiej isthatdebbiej changed the title DOC: Added example for get_printoption DOC: Added example for get_printoption, recfromtxt and recfromcsv Nov 17, 2022
@mattip
Copy link
Member

mattip commented Feb 15, 2023

I think we should close this. The examples do not add that much information.

@mattip mattip added the 57 - Close? Issues which may be closable unless discussion continued label Feb 15, 2023
@rossbar
Copy link
Contributor

rossbar commented Feb 15, 2023

I think we should close this. The examples do not add that much information.

Thanks @mattip . I had intended to try to expand on these examples a bit but since the PR originates from main on the fork, pushing to the fork is disallowed. I agree it's probably easiest to close this. Thanks @isthatdebbiej , if you're still interested in contributing I would recommend opening a new PR that:

  1. Originates from a branch dedicated to the fix (i.e. git checkout -b add-get_printoption-example)
  2. Focuses on a single proposed change.

@rossbar rossbar closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04 - Documentation 57 - Close? Issues which may be closable unless discussion continued
Projects
Development

Successfully merging this pull request may close these issues.

5 participants