Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BLD: update wheel builds on macos to macos-12 image #22612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 19, 2022
Merged

BLD: update wheel builds on macos to macos-12 image #22612

merged 14 commits into from
Nov 19, 2022

Conversation

mattip
Copy link
Member

@mattip mattip commented Nov 17, 2022

Redo the part of #22534 that didn't make it into the much larger #22525

xref @charris

@charris
Copy link
Member

charris commented Nov 17, 2022

🥇 Beat me to it.

@charris charris added this to the 1.24.0 release milestone Nov 17, 2022
@charris charris changed the title BUILD: update wheel builds on macos to macos-11 image BLD: update wheel builds on macos to macos-11 image Nov 17, 2022
@github-actions github-actions bot added the 36 - Build Build related PR label Nov 17, 2022
@charris
Copy link
Member

charris commented Nov 17, 2022

close/ropen

@charris charris closed this Nov 17, 2022
@charris charris reopened this Nov 17, 2022
@mattip
Copy link
Member Author

mattip commented Nov 17, 2022

I am seeing

NFO: /usr/local/bin/gfortran -Wall -g -arch x86_64 -Wall -g -undefined dynamic_lookup -bundle /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpv0zett_w/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpv0zett_w/src.macosx-10.9-x86_64-3.8/_test_abstract_interface_TestAbstractInterface_ext_modulemodule.o /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpv0zett_w/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpv0zett_w/src.macosx-10.9-x86_64-3.8/fortranobject.o /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpv0zett_w/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpt2nb9pct/foo.o /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpv0zett_w/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpv0zett_w/src.macosx-10.9-x86_64-3.8/_test_abstract_interface_TestAbstractInterface_ext_module-f2pywrappers2.o -L/opt/gfortran-darwin-x86_64-native/bin/../lib/gcc/x86_64-apple-darwin13.4.0/11.3.0 -L/opt/gfortran-darwin-x86_64-native/bin/../lib/gcc/x86_64-apple-darwin13.4.0/11.3.0/../../.. -L/opt/gfortran-darwin-x86_64-native/bin/../lib/gcc/x86_64-apple-darwin13.4.0/11.3.0/../../.. -lgfortran -o ./_test_abstract_interface_TestAbstractInterface_ext_module.cpython-38-darwin.so

   ld: library not found for -lm

@charris
Copy link
Member

charris commented Nov 17, 2022

The f2py tests are failing, same as before.

@charris
Copy link
Member

charris commented Nov 17, 2022

Almost there.

  + python /Users/runner/work/numpy/numpy/tools/openblas_support.py --check_version
  Traceback (most recent call last):
    File "/Users/runner/work/numpy/numpy/tools/openblas_support.py", line 319, in <module>
      test_version(args.check_version)
    File "/Users/runner/work/numpy/numpy/tools/openblas_support.py", line 297, in test_version
      raise ValueError(f"expected single threadpool_info result, got {data}")
  ValueError: expected single threadpool_info result, got []

Wonder what the problem was. I'll be glad to see the end of Python 3.8 in 1.25.x, it just causes us problems.

@mattip
Copy link
Member Author

mattip commented Nov 17, 2022

Strange. The delocate command is packaging OpenBLAS into the wheel, and the tests pass so it must be finding some blas to run. But threadpoolctl cannot find any information. The cpython3.9 run works fine.

@mattip
Copy link
Member Author

mattip commented Nov 17, 2022

I am rerunning the job.

@mattip
Copy link
Member Author

mattip commented Nov 18, 2022

Grasping at straws. I don't see any threadpoolctl issues around detection on python3.8, and the PyPy3.8 build passes so I don't understand what is wrong with CPython3.8.

@mattip
Copy link
Member Author

mattip commented Nov 18, 2022

It fails faster now 🙁 I will try disabling the check just so I can grab the artifact and try it locally

mattip
mattip commented Nov 18, 2022
View reviewed changes
azure-pipelines.yml
LAPACK: None
ATLAS: None
CC: /usr/bin/clang
condition: eq(variables['USE_OPENBLAS'], '0')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At one point these were different, but then we removed an env variable so they became the same

mattip
mattip commented Nov 18, 2022
View reviewed changes
tools/wheels/cibw_test_command.sh
fi
# Set available memory value to avoid OOM problems on aarch64.
# See gh-22418.
export NPY_AVAILABLE_MEM="4 GB"
if [[ $(python -c "import sys; print(sys.implementation.name)") == "pypy" ]]; then
# make PyPy more verbose, try to catc a segfault in
# numpy/lib/tests/test_function_base.py
# make PyPy more verbose, try to catch a segfault
python -c "import sys; import numpy; sys.exit(not numpy.test(label='full', verbose=2))"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably remove the verbosity increment, but PyPy is flaky enough that it makes sense to be defensive here.

@mattip mattip changed the title BLD: update wheel builds on macos to macos-11 image BLD: update wheel builds on macos to macos-12 image Nov 18, 2022
@mattip
Copy link
Member Author

mattip commented Nov 18, 2022

It seems the macos-11 image has some problems, I changed this to use macos-12 instead

@charris
Copy link
Member

charris commented Nov 19, 2022

Was going to say ... :)

@mattip
Copy link
Member Author

mattip commented Nov 19, 2022

All checks pass. If it is acceptable to skip the test on the macos 3.8 wheel build, this is ready for review.

@charris
Copy link
Member

charris commented Nov 19, 2022

If it is acceptable to skip the test on the macos 3.8 wheel build

Fine with me. We can drop the 3.8 wheel builds after the 1.24 branch.

@charris
Copy link
Member

charris commented Nov 19, 2022

@mattip ISTR ILP64 problems for aarch64. Has that been addressed?

@mattip
Copy link
Member Author

mattip commented Nov 19, 2022

aarch64 has both 32- and 64-bit interfaces tested. ppc64le was the one with only 32-bit interfaces available

@mattip
Copy link
Member Author

mattip commented Nov 19, 2022

xref #22610

@charris charris merged commit cd75790 into numpy:main Nov 19, 2022
@charris
Copy link
Member

charris commented Nov 19, 2022

Here we go. Thanks Matti.

@mattip mattip deleted the macos-11 branch December 27, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charris charris charris approved these changes

Assignees
No one assigned
Labels
36 - Build Build related PR
Projects
None yet
Milestone
1.24.0 release
Development

Successfully merging this pull request may close these issues.
2 participants
@mattip @charris