BUG: Ensure string aliases "int0", etc. remain valid for now
#22676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78673e3 to
7ed8df7
Compare
"int0", etc. remain valid for now
int0 and uint0 were accidentally dropped, the others just added as a test. We did successfully remove many Numeric types before, so these could probably be deprecated (it is a bit more annoying to do). These could probably just be removed, scikit-learn only noticed it in a single test (scipy probably not at all). But maybe not in 1.24
mattip
approved these changes
Nov 27, 2022
Co-authored-by: Matti Picus <[email protected]>
|
Thanks @seberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int0 and uint0 were accidentally dropped, the others just added as a test.
We did successfully remove many Numeric types before, so these could probably be deprecated (it is a bit more annoying to do).
These could probably just be removed,
even scipy only noticed it in a single testscikit-learn only noticed it in a single test (scipy probably not at all).. But maybe not in 1.24Closes gh-22672