DEP: deprecate product, cumproduct, sometrue, alltrue
#23314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip cirrus]
Rename `23314.deprecations,rst` to `23314,deprecation,rst`
charris
reviewed
Mar 2, 2023
Member
|
I fixed the circleci failure, wrong file name. |
[skip cirrus] [skip circle]
Member
|
Thanks Ralf. |
This was referenced Mar 3, 2023
seberg
reviewed
Mar 6, 2023
rgommers
added a commit
to rgommers/numpy
that referenced
this pull request
Mar 9, 2023
This follows up on a review comment on numpygh-23314 [skip cirrus] [skip circle]
rgommers
added a commit
to rgommers/numpy
that referenced
this pull request
Mar 10, 2023
This follows up on a review comment on numpygh-23314 [skip cirrus] [skip circle]
vasole
added a commit
to silx-kit/silx
that referenced
this pull request
Mar 21, 2023
6 tasks
BvB93
added a commit
to BvB93/numpy
that referenced
this pull request
May 8, 2023
weiji14
added a commit
to xarray-contrib/xbatcher
that referenced
this pull request
Jul 4, 2023
Remove usage of `np.product` that was deprecated in numpy 1.25.0, see numpy/numpy#23314.
weiji14
added a commit
to xarray-contrib/xbatcher
that referenced
this pull request
Jul 4, 2023
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/pre-commit/mirrors-prettier: v3.0.0-alpha.6 → v3.0.0-alpha.9-for-vscode](pre-commit/mirrors-prettier@v3.0.0-alpha.6...v3.0.0-alpha.9-for-vscode) - [github.com/pre-commit/mirrors-mypy: v1.1.1 → v1.4.1](pre-commit/mirrors-mypy@v1.1.1...v1.4.1) * Use np.prod instead of np.product Remove usage of `np.product` that was deprecated in numpy 1.25.0, see numpy/numpy#23314. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Wei Ji <[email protected]>
4 tasks
6 tasks
btjanaka
added a commit
to icaros-usc/pyribs
that referenced
this pull request
Sep 22, 2023
## Description <!-- Provide a brief description of the PR's purpose here. --> `np.product` is deprecated in numpy 1.25.0 -- see numpy/numpy#23314 This PR replaces our calls to `np.product` with `np.prod`. ## TODO <!-- Notable points that this PR has either accomplished or will accomplish. --> ## Questions <!-- Any concerns or points of confusion? --> ## Status - [x] I have read the guidelines in [CONTRIBUTING.md](https://github.com/icaros-usc/pyribs/blob/master/CONTRIBUTING.md) - [x] I have formatted my code using `yapf` - [x] I have tested my code by running `pytest` - [x] I have linted my code with `pylint` - [x] I have added a one-line description of my change to the changelog in `HISTORY.md` - [x] This PR is ready to go
btjanaka
added a commit
to icaros-usc/pyribs
that referenced
this pull request
Sep 25, 2023
<!-- Provide a brief description of the PR's purpose here. --> `np.product` is deprecated in numpy 1.25.0 -- see numpy/numpy#23314 This PR replaces our calls to `np.product` with `np.prod`. <!-- Notable points that this PR has either accomplished or will accomplish. --> <!-- Any concerns or points of confusion? --> - [x] I have read the guidelines in [CONTRIBUTING.md](https://github.com/icaros-usc/pyribs/blob/master/CONTRIBUTING.md) - [x] I have formatted my code using `yapf` - [x] I have tested my code by running `pytest` - [x] I have linted my code with `pylint` - [x] I have added a one-line description of my change to the changelog in `HISTORY.md` - [x] This PR is ready to go
3 tasks
R-O-C-K-E-T
added a commit
to R-O-C-K-E-T/Factorio-SAT
that referenced
this pull request
Aug 25, 2024
maresb
added a commit
to maresb/tensorizer
that referenced
this pull request
Jan 25, 2025
`numpy.product` was deprecated in numpy 1.25, with this [PR](numpy/numpy#23314) and removed in numpy 2.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-14584
As a note for reviewers: these functions were already not present in the reference guide, so no changes were needed there.