Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CI: only build cirrus wheels when requested #24286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 30, 2023
Merged

Conversation

andyfaff
Copy link
Member

No description provided.

@andyfaff
Copy link
Member Author

I've checked that [wheel build] triggers a wheel build in f4190e4, but doesn't in 2e4b2ac.

@charris, can you try adding a 36 - Build label to this PR, I can't do that myself?

When you add the label can you look at the cirrus-ci runner to check that adding the label triggered a wheel build? Note the last commit doesn't have [wheel build] in the commit message, so there's no dependency of the label and the commit message.

Lastly, the wheel build should activate on a tag beginning with v, but not if the tag contains dev0. We won't be able to test that until the next tag event.

@seberg seberg added the 36 - Build Build related PR label Jul 29, 2023
@charris
Copy link
Member

charris commented Jul 29, 2023

Looks like the Cirrus builds didn't go through.

@andyfaff andyfaff closed this Jul 30, 2023
@andyfaff andyfaff reopened this Jul 30, 2023
@andyfaff
Copy link
Member Author

It doesn't look like adding a label, or closing/opening a PR triggers any external CI. I'll make another commit to check if the label checking works.

@andyfaff
Copy link
Member Author

@charris 5ca2bca is building wheels. There is no [wheel build] message, it's only building them because the label is present.
As mentioned in my last post just adding a label won't be sufficient to trigger a build, you then have to make a commit.

I hope this logic is sufficient to close #24280.

@andyfaff
Copy link
Member Author

@rgommers, is the logic in here sufficient? I can remove the label tests if required.

@rgommers
Copy link
Member

Ah this looks good, thanks @andyfaff. And yes, it'd be great to remove all label-based logic.

@rgommers
Copy link
Member

@charris, can you try adding a 36 - Build label to this PR, I can't do that myself?

Let me add you to the triage team now so you have permissions.

@andyfaff
Copy link
Member Author

Commented out the label related things (just in case it's required later).

  • wheel build once a week in a cron job
  • if a tag is made that doesn't have dev0 in the tag name
  • if [wheel build] is included in the commit message.

@rgommers
Copy link
Member

That sounds like the right logic to me, thanks!

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Jul 30, 2023
@charris charris added this to the 1.26.0 release milestone Jul 30, 2023
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's give this a go. Thanks @andyfaff!

@rgommers rgommers merged commit 1a0066b into numpy:main Jul 30, 2023
@andyfaff andyfaff deleted the cirrus2 branch July 30, 2023 21:30
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 3, 2023
@charris charris removed this from the 1.26.0 release milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
36 - Build Build related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants