-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
CI: only build cirrus wheels when requested #24286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've checked that @charris, can you try adding a When you add the label can you look at the cirrus-ci runner to check that adding the label triggered a wheel build? Note the last commit doesn't have Lastly, the wheel build should activate on a tag beginning with v, but not if the tag contains dev0. We won't be able to test that until the next tag event. |
Looks like the Cirrus builds didn't go through. |
It doesn't look like adding a label, or closing/opening a PR triggers any external CI. I'll make another commit to check if the label checking works. |
@rgommers, is the logic in here sufficient? I can remove the label tests if required. |
Ah this looks good, thanks @andyfaff. And yes, it'd be great to remove all label-based logic. |
Let me add you to the triage team now so you have permissions. |
Commented out the label related things (just in case it's required later).
|
That sounds like the right logic to me, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's give this a go. Thanks @andyfaff!
No description provided.