BUG: fix comparisons between masked and unmasked structured arrays #24556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24554, where it was noted that currently comparing a masked structured array with an unmasked one fails:
While looking at the code, it seemed obvious that a correction to the mask shape done inside an
if
statement should really be outside. A quick test confirmed that. So, the second commit fixes that too. I can make it 2 PRs if need be (but am trying to just be done...)Not sure about the milestone. I put 1.26.0, but that may be too late. This definitely is not very urgent, since the bug has been there for years.