ENH: Refactor the typing "reveal" tests using typing.assert_type
#24635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@charris I'd say that this might be worth backporting to 1.26 (marked as such as of now(, though could you let me handle the backport? The rebasing will require a bit of work as a number of 2.0-only changes will have to be reverted. |
|
Thanks Bas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21505
Python 3.11 will add the new
typing.assert_typefunction, which is used for validating that two types are equivalent while static type checking. Switching from the type-comments, currently used for validating the revealed type, totyping.assert_typehas a number advantages:typing.assert_typeis agnostic w.r.t. the particular type checkers, so this means we could in principle easily run the tests with other type checkers besides mypy with fairly minimal changes to the relevant test functions.Probably want to merge after #24634 and #24587 to minimize merge conflicts.
Examples