-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
CI: enable use of Cirrus CI compute credits by collaborators #24695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See docs at https://cirrus-ci.org/pricing/#compute-credits Starting with collaborators only, because those are the only ones who should trigger wheel builds, and also author the vast majority of PRs where architecture-specific CI is actually useful. We can always set it to an unconditional "true" later on. xref numpygh-24280 [skip actions] [skip azp] [skip circle]
That worked, and at the end it said "no compute credit were charged", because we still have free credits available for this month. |
Thanks Ralf. |
@@ -101,6 +103,7 @@ macosx_arm64_task: | |||
###################################################################### | |||
|
|||
wheels_upload_task: | |||
use_compute_credits: $CIRRUS_USER_COLLABORATOR == 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary here, because it depends on the wheels being made, and they won't be made unless CIRRUS_USER_COLLABORATOR == True
.
@rgommers do you know what The CIRRUS_USER_COLLABORATOR is defined as:
Does that mean they're:
|
I think it's defined as anyone who is a member of a team in the org, I suspect triage rights are enough. But the docs aren't clear on it, so I guess we'll find out.
I don't think that that will matter.
Yes, that is how it will work I believe. However, we haven't been cut off yet when free credits run out, so it's hard to tell. On SciPy we're well over the 50 free credits limit by now, and nothing has started failing yet. So I think they're phasing it out gently. |
eek, that's probably my fault. |
See docs at https://cirrus-ci.org/pricing/#compute-credits Starting with collaborators only, because those are the only ones who should trigger wheel builds, and also author the vast majority of PRs where architecture-specific CI is actually useful. We can always set it to an unconditional "true" later on.
xref gh-24280
[skip actions] [skip azp] [skip circle]