Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CI: enable use of Cirrus CI compute credits by collaborators #24695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

rgommers
Copy link
Member

See docs at https://cirrus-ci.org/pricing/#compute-credits Starting with collaborators only, because those are the only ones who should trigger wheel builds, and also author the vast majority of PRs where architecture-specific CI is actually useful. We can always set it to an unconditional "true" later on.

xref gh-24280

[skip actions] [skip azp] [skip circle]

See docs at https://cirrus-ci.org/pricing/#compute-credits
Starting with collaborators only, because those are the only ones who
should trigger wheel builds, and also author the vast majority of
PRs where architecture-specific CI is actually useful.
We can always set it to an unconditional "true" later on.

xref numpygh-24280

[skip actions] [skip azp] [skip circle]
@rgommers
Copy link
Member Author

The little button with a blue star saying "compute credits" is new on this job:

image

The tooltip on that button says that cost will be calculated at the end of the job.

@rgommers
Copy link
Member Author

That worked, and at the end it said "no compute credit were charged", because we still have free credits available for this month.

@rgommers
Copy link
Member Author

Well, the dashboard is disagreeing, interesting:

image

I'll keep an eye on it and check it all makes sense to me.

@charris charris merged commit e7462a8 into numpy:main Sep 13, 2023
@charris
Copy link
Member

charris commented Sep 13, 2023

Thanks Ralf.

@rgommers rgommers deleted the cirrus-credits branch September 13, 2023 19:16
@@ -101,6 +103,7 @@ macosx_arm64_task:
######################################################################

wheels_upload_task:
use_compute_credits: $CIRRUS_USER_COLLABORATOR == 'true'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary here, because it depends on the wheels being made, and they won't be made unless CIRRUS_USER_COLLABORATOR == True.

@andyfaff
Copy link
Member

@rgommers do you know what CIRRUS_USER_COLLABORATOR represents? For example, before the free credits run out each month do PRs get run by everyone, but restricted when they run out?

The CIRRUS_USER_COLLABORATOR is defined as:

if a user initialized a build is already a contributor to the repository

Does that mean they're:

  • a maintainer? (whether commit rights or triage rights)
  • had commits merged at some point in the past?

@rgommers
Copy link
Member Author

I think it's defined as anyone who is a member of a team in the org, I suspect triage rights are enough. But the docs aren't clear on it, so I guess we'll find out.

had commits merged at some point in the past?

I don't think that that will matter.

For example, before the free credits run out each month do PRs get run by everyone, but restricted when they run out?

Yes, that is how it will work I believe. However, we haven't been cut off yet when free credits run out, so it's hard to tell. On SciPy we're well over the 50 free credits limit by now, and nothing has started failing yet. So I think they're phasing it out gently.

@andyfaff
Copy link
Member

SciPy we're well over the 50 free credits limit by now, and nothing has started failing yet

eek, that's probably my fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants