WIP, BLD: PYTHONSAFEPATH support #24944
Open
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes numpy#24907 * we can avoid `PYTHONSAFEPATH` causing our build to choke on the fact that the NumPy build requires Python code to execute an "unsafe" import from its own build dir * here, the chosen approach is to perform the import "manually," but we could also decide to refuse to build if that environment variable is set for example, depending on our view on the matter [ci skip] [skip cirrus]
Member
|
Maybe the fix is rather embrace the module nature, there already is an And fix the imports to use |
Member
|
Is this still relevant? |
Member
|
Doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BUG: failed to build with
PYTHONSAFEPATH=1environment variable #24907marked as WIP (and CI skipped) for now because this is ugly and we could also just decide not to fix it at all, and/or to error out when that env var is set with a clear error message
we can avoid
PYTHONSAFEPATHcausing our build to choke on the fact that the NumPy build requires Python code to execute an "unsafe" import from its own build dirhere, the chosen approach is to perform the import "manually," but we could also decide to refuse to build if that environment variable is set for example, depending on our view on the matter
[ci skip] [skip cirrus]