BUG: Don't try to grab callback modules #25212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be ready to go when the CI is green. |
7ab9bba to
cd049a8
Compare
tylerjereddy
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
I'm not an f2py expert but this feature branch allows SciPy main to build again in my hands as well, and the SciPy testsuite looks good too.
Since the source patch is small, there are regression tests, and NumPy CI is passing, maybe I'll go ahead and merge it.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-25211. Snuck in over at #25186.
Forgot that
f2pyhas__user__as a "use" directive for callbacks..Thanks @tylerjereddy for the easy to track defect ^_^