Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "MAINT: Pin scipy-openblas version." #25240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

charris
Copy link
Member

@charris charris commented Nov 23, 2023

This reverts commit fc324e3 in order to reproduce
ci failures with unpinned openblas.

@mattip has made some fixes that allows tests to pass.

@mattip
Copy link
Member

mattip commented Nov 24, 2023

The failure is in the Check OpenBLAS version step, which fails to import numpy on windows:

DLL load failed while importing _multiarray_umath: The specified module could not be found

That CI step is no longer relevant since the build uses "whatever version is supplied by pip install scipy-openblas" and not a version fixed by a CI environment variable. But I would expect it to fail on the version check, and not when importing NumPy.

@mattip
Copy link
Member

mattip commented Nov 24, 2023

Something is strange in the CI windows run. It has a "Download/Install OpenBLAS" step, which is not needed when using the scip-openblas wheels. During the build, the meson discovery is finding scipy-openblas found: YES 0.3.24.dev, so it is using the wheel to build. But then it is copying the OpenBLAS from the non-scipy-openblas wheel. I think the 'Download / Install OpenBLAS', Copy OpenBLAS DLL to site-packages, and the 'Check OpenBLAS version' build steps should be removed, like on main.

@mattip
Copy link
Member

mattip commented Nov 26, 2023

@charris CI is passing

@charris charris added 34 - Reversion Reversion of previous commit or merge 36 - Build Build related PR and removed 25 - WIP labels Dec 5, 2023
@charris charris merged commit af5a399 into numpy:maintenance/1.26.x Dec 5, 2023
@charris charris deleted the show-openblas-failure branch December 5, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
34 - Reversion Reversion of previous commit or merge 36 - Build Build related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants