Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG: Fix non-contiguous 32-bit memory load when ARM/Neon is enabled #25243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2023
Merged

BUG: Fix non-contiguous 32-bit memory load when ARM/Neon is enabled #25243

merged 1 commit into from
Dec 1, 2023

Conversation

seiko2plus
Copy link
Member

closes #25231

@seiko2plus seiko2plus added 09 - Backport-Candidate PRs tagged should be backported component: SIMD Issues in SIMD (fast instruction sets) code or machinery labels Nov 24, 2023
@seiko2plus seiko2plus marked this pull request as ready for review November 24, 2023 08:35
@seiko2plus seiko2plus mentioned this pull request Nov 24, 2023
Closed
@seiko2plus seiko2plus changed the title BUG: Fix non-contiguous memory load when ARM/Neon is enabled BUG: Fix non-contiguous 32-bit memory load when ARM/Neon is enabled Nov 24, 2023
@seberg
Copy link
Member

seberg commented Nov 24, 2023

If it's easy, it would be nice to have a test. I am confused by how long this seems to have gone unnoticed.

@charris charris merged commit f209869 into numpy:main Dec 1, 2023
@charris
Copy link
Member

charris commented Dec 1, 2023

Thanks Sayed. It would be good to have a test for this.

@charris charris mentioned this pull request Dec 18, 2023
Merged
@seberg
Copy link
Member

seberg commented Dec 19, 2023

I am getting a lot of warnings these days:

[76/310] Compiling C object numpy/_core/libloops_hyperboli...baseline.a.p/meson-generated_loops_hyperbolic.dispatch.c.o
In file included from ../numpy/_core/src/umath/loops_hyperbolic.dispatch.c.src:9:
In file included from ../numpy/_core/src/common/simd/simd.h:85:
In file included from ../numpy/_core/src/common/simd/neon/neon.h:76:
../numpy/_core/src/common/simd/neon/memory.h:56:56: warning: variable 'a' is uninitialized when used here [-Wuninitialized]
    a = vld1q_lane_s32((const int32_t*)ptr,            a, 0);
                                                       ^
/Library/Developer/CommandLineTools/usr/lib/clang/15.0.0/include/arm_neon.h:9481:20: note: expanded from macro 'vld1q_lane_s32'
  int32x4_t __s1 = __p1; \
                   ^~~~
../numpy/_core/src/common/simd/neon/memory.h:55:5: note: variable 'a' is declared here
    int32x4_t a;
    ^
1 warning generated.

Wondering if that is related to the change or just an unrelated thing that I didn't notice it much before?

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Dec 23, 2023
@seberg seberg mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mousius Mousius Mousius approved these changes

Assignees
No one assigned
Labels
00 - Bug component: SIMD Issues in SIMD (fast instruction sets) code or machinery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: segfault when array with dtype=np.float32 is sliced then squared
4 participants
@seiko2plus @seberg @charris @Mousius