-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
BUG: enable linking of external libraries in the f2py Meson backend #25297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton for this. It is pragmatic (though the resulting meson.build
files are a little odd looking) so I think it would be good to go as soon as:
- Some documentation is added (especially the migrating to
meson
page) - Also to the CLI help text (
f2py2e
)
It is worth noting that this functionality can also be achieved by setting up either the environment variables or by using native files, but I think it is a good idea to have as part of f2py
as well.
I will update the migrating to meson page. However, regarding the second point, isn't this already enough? |
Yup it is actually (forgot it doesn't have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, lets get this in, thanks @andrea-bia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, last thing, could you squash the changes into one commit? Either:
BUG: Add external library handling for meson [f2py]
or ENH:
(similar)
f58e204
to
8afdac9
Compare
Thanks @andrea-bia. |
The current state of the f2py meson code fails to transmit external libraries necessary for linking. In contrast, the previous distutils backend successfully achieved this functionality.
I tried to add few lines of code to bring back the functionality