Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TST: Use meson for testing f2py #25427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

charris
Copy link
Member

@charris charris commented Dec 19, 2023

Backport of #25111.

Closes #25109.

Essentially:

Also reworked test_docs to run with spin.

image

Additionally (features added):

  • The compile() call will now use the meson backend as well
    • Ideally I'd like this command to go away completely..
  • MAINT,TST: Use meson for compiler checks [f2py]

  • MAINT: Cache the compiler checks [f2py]

  • MAINT,TST: Always use meson [f2py]

  • TST: Rework to have a build_meson [f2py]

  • MAINT,TST: Simplify the meson backend [f2py]

  • TST: Use the build_meson function [f2py]

  • MAINT,TST: Minor cleanup [f2py]

  • TST: Ensure TestDocAdvanced runs with spin [f2py]

  • TST: Use cleanup meson backend [f2py]

  • MAINT,TST: Generalize build_meson [f2py]

  • TST: Use a helper for spin tests [f2py]

  • MAINT: Simplify meson backend [f2py]

  • TST: Handle unsupported compilers [f2py]

  • TST: Fix gibberish in [f2py] documentation test

  • CI: Add meson for cygwin runs

  • TST: Skips for 32-bit errors [f2py]

  • TST: Skip for cygwin since meson is old [f2py]

  • CI: Revert grabbing meson on cygwin

The version is too old to be of use

  • TST: Cleanup old distutils builder [f2py]

  • TST: Skip cygwin better [f2py]

  • TST: Don't touch distutils

  • MAINT: Vendor in distutils testing requirement

  • TST: Try removing cygwin restrictions

  • MAINT: Cleanup some tests [f2py]

  • TST: Try to use concurrency for i/o bounds [f2py]

  • TST: Mark slow tests [f2py]

Should finish in around a minute now

@charris charris added 05 - Testing component: numpy.f2py 08 - Backport Used to tag backport PRs component: CI Meson Items related to the introduction of Meson as the new build system for NumPy labels Dec 19, 2023
@charris charris added this to the 1.26.3 release milestone Dec 19, 2023
@charris
Copy link
Member Author

charris commented Dec 19, 2023

Hmm, this breaks emscripten, which is currently disabled in main because it doesn't work with meson.

@HaoZeke Do you recall if numpy/f2py/tests/test_compile_function.py passed for 32 bit Windows in main before it was removed? Or was it removed first.

@HaoZeke
Copy link
Member

HaoZeke commented Dec 19, 2023

Hmm, this breaks emscripten, which is currently disabled in main because it doesn't work with meson.

@HaoZeke Do you recall if numpy/f2py/tests/test_compile_function.py passed for 32 bit Windows in main before it was removed? Or was it removed first.

AFAIK it should have been preemptively skipped by #25073 (comment), which has been in place for around 6 years...

@charris charris marked this pull request as draft December 20, 2023 21:08
@charris charris closed this Dec 23, 2023
@charris charris reopened this Dec 23, 2023
HaoZeke and others added 2 commits December 23, 2023 20:57
* MAINT,TST: Use meson for compiler checks [f2py]

* MAINT: Cache the compiler checks [f2py]

* MAINT,TST: Always use meson [f2py]

* TST: Rework to have a build_meson [f2py]

* MAINT,TST: Simplify the meson backend [f2py]

* TST: Use the build_meson function [f2py]

* MAINT,TST: Minor cleanup [f2py]

* TST: Ensure TestDocAdvanced runs with spin [f2py]

* TST: Use cleanup meson backend [f2py]

* MAINT,TST: Generalize build_meson [f2py]

* TST: Use a helper for spin tests [f2py]

* MAINT: Simplify meson backend [f2py]

* TST: Handle unsupported compilers [f2py]

* TST: Fix gibberish in [f2py] documentation test

* CI: Add meson for cygwin runs

* TST: Skips for 32-bit errors [f2py]

* TST: Skip for cygwin since meson is old [f2py]

* CI: Revert grabbing meson on cygwin

The version is too old to be of use

* TST: Cleanup old distutils builder [f2py]

* TST: Skip cygwin better [f2py]

* TST: Don't touch distutils

* MAINT: Vendor in distutils testing requirement

* TST: Try removing cygwin restrictions

* MAINT: Cleanup some tests [f2py]

* TST: Try to use concurrency for i/o bounds [f2py]

* TST: Mark slow tests [f2py]

Should finish in around a minute now
@charris charris removed this from the 1.26.4 release milestone Feb 5, 2024
@charris charris closed this Feb 5, 2024
@charris
Copy link
Member Author

charris commented Feb 5, 2024

Leaving this for 2.0.0

@charris charris deleted the backport-25111 branch February 5, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 - Testing 08 - Backport Used to tag backport PRs component: CI component: numpy.f2py Meson Items related to the introduction of Meson as the new build system for NumPy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants