MAINT: make the import-time check for old Accelerate more specific #25450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids triggering a hard import error on any warning; something that may be due to other reasons than using old Accelerate (e.g., numpygh-25433 is for a specific combination of Clang, macOS and OpenBLAS). Closes numpygh-25433
|
Okay, second time the dumb linter fails and it doesn't reproduce locally. It doesn't make sense here to make these lines even shorter, and they were already too long to begin with, so I'll just ignore that. |
|
@climbfuji this should fix the issue you were seeing on spack/spack#41742 |
|
Thanks @rgommers ! Looking forward to trying that out when the next release of numpy finds its way into spack. |
|
Thanks Ralf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids triggering a hard import error on any warning; something that may be due to other reasons than using old Accelerate (e.g., gh-25433 is for a specific combination of Clang, macOS and OpenBLAS).
Closes gh-25433