Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG: remove vestiges of array_api [wheel build] #25924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2024
Merged

BUG: remove vestiges of array_api [wheel build] #25924

merged 1 commit into from
Mar 4, 2024

Conversation

mattip
Copy link
Member

@mattip mattip commented Mar 4, 2024

Fixes #25923 by removing unneeded work-around for array_api warning.

This is only seen in wheel building, since only there do we do numpy.test()

mattip
mattip commented Mar 4, 2024
View reviewed changes
numpy/__init__.py
import numpy.array_api as array_api
return array_api
raise AttributeError("`numpy.array_api` is not available from "
"numpy 2.0 onwards")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stanza could instead just be removed, but this way gives a nicer error.

@mattip
Copy link
Member Author

mattip commented Mar 4, 2024

The wheel test on macos_arm64 failed in test_sort_float[f-N125]. Is that a known problem? Also: there are warnings about invalid casts or divide by 0 in

test_dunder_round_edgecases[2147483647--1]
test_linalg.py::TestDet::test_types[complex128]
test_linalg.py::TestDet::test_types[complex64]

and f2py raises warnings in

test_f2py2e.py::test_debugcapi_bld
test_f2py2e.py::test_npdistop

It would be nice to fix these in a different PR.

@rgommers
Copy link
Member

rgommers commented Mar 4, 2024

The wheel test on macos_arm64 failed in test_sort_float[f-N125]. Is that a known problem? Also: there are warnings about invalid casts or divide by 0 in

Yes, see gh-25464

rgommers
rgommers approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Matti.

Guess we should have a regular CI job that use numpy.test('full') instead of only doing that in the wheel builds. I'll have a look at that.

@rgommers rgommers merged commit b9c4c21 into numpy:main Mar 4, 2024
@rgommers rgommers added this to the 2.0.0 release milestone Mar 4, 2024
@mattip mattip deleted the api branch May 5, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
00 - Bug component: numpy.array_api
Projects
None yet
Milestone
2.0.0 release
Development

Successfully merging this pull request may close these issues.

Calling numpy.test(label="full") hits "import numpy.array_api"
2 participants
@mattip @rgommers