Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH add hash based unique #26018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seberg merged 53 commits into from
Feb 27, 2025
Merged

ENH add hash based unique #26018

Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
2933930
ENH add hash based unique
adrinjalali Mar 14, 2024
8da2e72
getting closer
adrinjalali Mar 14, 2024
961ef5b
trying to expose as a module
adrinjalali Mar 15, 2024
a6b1847
trying to create a module
adrinjalali Mar 17, 2024
1f1c36c
fix build
adrinjalali Mar 18, 2024
0bc43c3
...
adrinjalali Mar 18, 2024
f94cf89
Merge remote-tracking branch 'upstream/main' into unique-cpp
adrinjalali Mar 18, 2024
a37b151
segfault fix, imported numpy
adrinjalali Mar 19, 2024
8f42b0b
getting unique back, refcount issues exist
adrinjalali Mar 19, 2024
f56634f
unique works
adrinjalali Mar 19, 2024
bce7534
remove header
adrinjalali Mar 19, 2024
0c6c588
cleanups and comments
adrinjalali Mar 21, 2024
9b7d6f6
change type
adrinjalali Mar 21, 2024
85cf692
fix for initialization issue
adrinjalali Mar 21, 2024
3db3349
trying to move module
adrinjalali Mar 22, 2024
8d4b6be
Merge remote-tracking branch 'upstream/main' into unique-cpp
adrinjalali May 13, 2024
9e7d671
Revert "trying to move module"
adrinjalali May 13, 2024
a4e8a29
use unordered_set and use a finally construct to handle exceptions
adrinjalali Sep 19, 2024
6a8c69c
Merge remote-tracking branch 'upstream/main' into unique-cpp
adrinjalali Sep 19, 2024
0c3b889
handle C++ exceptions, and use explicit types
adrinjalali Sep 20, 2024
cc39a50
make it C importable
adrinjalali Sep 23, 2024
92adb26
add missing header file
adrinjalali Sep 23, 2024
8b7ad2e
fix skip API test
adrinjalali Sep 23, 2024
8f95240
rename _core.unique to _core._unique
adrinjalali Sep 23, 2024
1d0c596
use _unique name
adrinjalali Sep 23, 2024
ed4ea89
Merge remote-tracking branch 'upstream/main' into unique-cpp
adrinjalali Jan 9, 2025
8adbf70
add freethreaded slot
adrinjalali Jan 9, 2025
a8e69ff
apply comments from review
adrinjalali Jan 14, 2025
cdf3af9
Merge remote-tracking branch 'upstream/main' into unique-cpp
adrinjalali Jan 14, 2025
fc1d50e
remove own module, fix segfault
adrinjalali Jan 14, 2025
5dbdf48
raise NotImplementedError instead of returning None
adrinjalali Jan 14, 2025
c8b9d22
release and regrab GIL
adrinjalali Jan 19, 2025
a9df742
fix GIL issues and compile separately
adrinjalali Jan 20, 2025
5333e80
Merge remote-tracking branch 'upstream/main' into unique-cpp
adrinjalali Jan 20, 2025
3bb7c97
add np_core_dep dependency, hoping it fixes the issue
adrinjalali Jan 23, 2025
95a577b
remove include
adrinjalali Jan 23, 2025
724b794
debug ...
adrinjalali Jan 23, 2025
1abc6b5
debug ...
adrinjalali Jan 23, 2025
214cd06
Py_INCREF needs the GIL
adrinjalali Jan 23, 2025
8c184ab
Merge remote-tracking branch 'upstream/main' into unique-cpp
adrinjalali Jan 23, 2025
113e021
revert debug info in CI
adrinjalali Jan 23, 2025
c733f75
Merge highway submodule changes from main
seberg Jan 24, 2025
ae0e936
Merge remote-tracking branch 'upstream/main' into unique-cpp
adrinjalali Feb 1, 2025
b50e7f3
reviews
adrinjalali Feb 20, 2025
712a5cf
add test for ValueError
adrinjalali Feb 20, 2025
8a45f04
changelog
adrinjalali Feb 20, 2025
4999daa
Merge remote-tracking branch 'upstream/main' into unique-cpp
adrinjalali Feb 20, 2025
ab86574
use macro to return notimplemented
adrinjalali Feb 21, 2025
08d7d62
Merge remote-tracking branch 'upstream/main' into unique-cpp
adrinjalali Feb 22, 2025
e1e2ddf
Apply suggestions from code review
seberg Feb 25, 2025
f96411a
MAINT,ENH: Smaller reorgs/maint and use `sorted=False` for `unique_va…
seberg Feb 25, 2025
2319947
Ensure we don't iterate if iterator is empty (also change thread stat…
seberg Feb 25, 2025
e188bf3
DOC: unique_values doc examples may have different order now
seberg Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Py_INCREF needs the GIL
  • Loading branch information
@adrinjalali
adrinjalali committed Jan 23, 2025
commit 214cd061cdf3e551c5d4db04db35928ab2fab19f
2 changes: 1 addition & 1 deletion numpy/_core/src/multiarray/unique.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ PyObject* unique(PyArrayObject *self)
// does this need to have the same lifetime as the array?
npy_intp dims[1] = {(npy_intp)hashset.size()};
PyArray_Descr *descr = PyArray_DESCR(self);
Py_INCREF(descr);
NPY_ALLOW_C_API;
Py_INCREF(descr);
PyObject *res_obj = PyArray_NewFromDescr(
Copy link
Member

@seberg seberg Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there was a C++ exception after this, we would leak it... But, I don't think that is possible, so let's not worry about it.

&PyArray_Type,
descr,
Expand Down