Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MNT: replace _PyDict_GetItemStringWithError with PyDict_GetItemStringRef #26282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seberg merged 5 commits into from
Apr 17, 2024
Merged

MNT: replace _PyDict_GetItemStringWithError with PyDict_GetItemStringRef #26282

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
407689c
MNT: replace _PyDict_GetItemStringWithError with PyDict_GetItemStringRef
ngoldbaum Apr 15, 2024
64ffcd1
MNT: fix issue spotted in code review
ngoldbaum Apr 15, 2024
5d67699
MNT: fix two more issues spotted in code review
ngoldbaum Apr 16, 2024
90c8049
MNT: more missing decrefs spotted in code review
ngoldbaum Apr 16, 2024
26f7421
MNT: delete unnecessary decrefs (covered by goto fail logic)
ngoldbaum Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
MNT: delete unnecessary decrefs (covered by goto fail logic)
  • Loading branch information
@ngoldbaum
ngoldbaum committed Apr 16, 2024
commit 26f74212c47eccced0f3fe1fef16e76e02f5c03b
3 changes: 0 additions & 3 deletions numpy/_core/src/multiarray/ctors.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2394,22 +2394,19 @@ PyArray_FromInterface(PyObject *origin)
PyErr_SetString(PyExc_TypeError,
"strides must be a tuple");
Py_DECREF(ret);
Py_DECREF(attr);
goto fail;
}
if (n != PyTuple_GET_SIZE(attr)) {
PyErr_SetString(PyExc_ValueError,
"mismatch in length of strides and shape");
Py_DECREF(ret);
Py_DECREF(attr);
goto fail;
}
for (i = 0; i < n; i++) {
PyObject *tmp = PyTuple_GET_ITEM(attr, i);
strides[i] = PyArray_PyIntAsIntp(tmp);
if (error_converting(strides[i])) {
Py_DECREF(ret);
Py_DECREF(attr);
goto fail;
}
}
Expand Down