Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG: Fix invalid constructor in string_fastsearch.h with C++ >= 20. #26330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Romain-Geissler-1A
Copy link
Contributor

Backport of #26324 in the branch 2.0.

This is an error with -std=gnu++20 at least with gcc 11 to 13, and will
be an explicit warning with gcc >= 14. See
https://godbolt.org/z/YdoTc7r8f

In practice, it avoids these compilation errors:

In file included from ../numpy/_core/src/umath/string_ufuncs.cpp:20:
../numpy/_core/src/umath/string_fastsearch.h:63:31: error: expected unqualified-id before ')' token
   63 |     CheckedIndexer<char_type>()
      |                               ^
../numpy/_core/src/umath/string_fastsearch.h:69:40: error: expected ')' before '*' token
   69 |     CheckedIndexer<char_type>(char_type *buf, size_t len)
      |                              ~         ^~
      |
@charris charris added the 08 - Backport Used to tag backport PRs label Apr 23, 2024
@charris charris added this to the 2.0.0 release milestone Apr 23, 2024
@charris charris merged commit 6ac1312 into numpy:maintenance/2.0.x Apr 23, 2024
60 of 61 checks passed
@charris
Copy link
Member

charris commented Apr 23, 2024

Thanks @Romain-Geissler-1A .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
00 - Bug 08 - Backport Used to tag backport PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants