Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CI: start building Windows free-threaded wheels #27560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Oct 15, 2024

Builds on top of gh-27550 to actually build the free-threaded wheels for Windows (both 64-bit and 32-bit). Should be back-portable for 2.1.3.

Closes gh-27527.

(marked draft until gh-27550 is merged)

@rgommers rgommers added 14 - Release 09 - Backport-Candidate PRs tagged should be backported 36 - Build Build related PR 39 - free-threading PRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703) labels Oct 15, 2024
@rgommers rgommers added this to the 2.2.0 release milestone Oct 15, 2024
@rgommers rgommers marked this pull request as draft October 15, 2024 13:25
@rgommers rgommers changed the title BLD: start building Windows free-threaded wheels CI: start building Windows free-threaded wheels Oct 15, 2024
@rgommers rgommers marked this pull request as ready for review October 15, 2024 14:59
@rgommers
Copy link
Member Author

This is good to go now. The first two commits have been merged, only the third one is new. All wheel build jobs passed.

@mattip
Copy link
Member

mattip commented Oct 15, 2024

Cool, thanks. A 32-bit free-threading windows wheel might be too much but 🤷

@mattip mattip merged commit 10a9e2e into numpy:main Oct 15, 2024
111 of 113 checks passed
@rgommers rgommers deleted the win-whl-nogil branch October 15, 2024 15:17
@rgommers
Copy link
Member Author

Cool, thanks. A 32-bit free-threading windows wheel might be too much but 🤷

Yeah, I just added it because it worked out of the box, and it seems easier to do now than to deal with a request for it later. I'm not really attached to it though, if it becomes a problem we can drop it.

@mattip
Copy link
Member

mattip commented Oct 15, 2024

I kicked off a wheel build manually to upload the wheels to scientific-python-nightly

@ngoldbaum
Copy link
Member

Thanks Matti and Ralf for handling this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14 - Release 36 - Build Build related PR 39 - free-threading PRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703) component: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: build of python3.13t in windows fails
4 participants