BUG: f2py: fix issues with thread-local storage define #27729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a continuing source of issues, therefore in this commit we: - stop using `threads.h` completely, - better document what is happening, and - ensure the f2py TLS define stays unchanged so users can override it at build time by passing the define as a compile flag. Closes numpygh-27718
HaoZeke
reviewed
Nov 10, 2024
HaoZeke
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
This seems good to go to me, but I'll let @tylerjereddy make the final call.
|
Yeah, the last two commits were just comment improvements and the cognate SciPy PR referenced seems to have a clear example of the define switch indeed. |
|
Thanks Ralf, Rohit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuing source of issues, therefore we:
threads.hcompletely,Closes gh-27718
Opening as Draft to get a confirmation about it working on macOS + GCC, and also to fix the SciPy side of the problem with the documented approach of overridingdoneF2PY_THREAD_LOCAL_DECL.Let's not backport this PR I'd say, since there's a nonzero chance that it breaks again on some platform we don't test on.