Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG: update check for highway compiler support #28088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

ngoldbaum
Copy link
Member

Fixes #28087

I'm able to build numpy with TSAN after applying this change.

@ngoldbaum ngoldbaum requested a review from Mousius January 2, 2025 18:38
@charris
Copy link
Member

charris commented Jan 2, 2025

I'm not clear how this changes things by removing one of the or entries. Seems that makes it less likely to define NPY_DISABLE_HIGHWAY_SORT. Is that the intent?

@ngoldbaum
Copy link
Member Author

Yes, AIUI, Highway fixed the issues with clang sanitizers so we need to make this static check match the dynamic check inside highway.

@Mousius
Copy link
Member

Mousius commented Jan 2, 2025

@charris this mirrors the logic in https://github.com/google/highway/blob/master/hwy/contrib/sort/shared-inl.h#L130-L138, we keep missing this as we do updates to Highway 🙀

It has annoyed me sufficiently to get around to raising google/highway#2421 so we can maintain the checks in one place - this is a stop-gap until that lands and we have a more permanent fix.

@Mousius Mousius merged commit bba6256 into numpy:main Jan 2, 2025
68 checks passed
@Mousius
Copy link
Member

Mousius commented Jan 2, 2025

Thanks for your patience and quick fix @ngoldbaum! Hopefully the last time we need to fix this 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Cannot build with clang thread sanitizer
3 participants