FIX: Use the NPY_TIME_T macro everywhere #2856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, two (critical) parts of the code used `time_t` instead of `NPY_TIME_T`. Due to the fact, that most of the time `NPY_TIME_T` was equal to `time_t`, this bug didn't show up. But in mingw, `NPY_TIME_T` is actually equal to `__time64_t` and then this causes 64 bit integers to be cast into 32 bit integers (thus becoming negative), which causes localtime() to fail in mingw. Fixes numpygh-568.
|
Looks good to me. I'll leave the ticket open until datetime gets wider testing. |
charris
added a commit
that referenced
this pull request
Dec 27, 2012
FIX: Use the NPY_TIME_T macro everywhere
|
Thanks. Backported in #2857. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, two (critical) parts of the code used
time_tinstead ofNPY_TIME_T. Due to the fact, that most of the timeNPY_TIME_Twas equal totime_t, this bug didn't show up. But in mingw,NPY_TIME_Tis actually equalto
__time64_tand then this causes 64 bit integers to be cast into 32 bitintegers (thus becoming negative), which causes localtime() to fail in mingw.
Fixes gh-568.