BUG: Respect print options in masked array formatting #28698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5da334 to
7353323
Compare
c2c46cf to
31eca68
Compare
Previously, the string representation of masked arrays did not honor
global print options such as floatmode, precision, and suppress.
This led to inconsistencies between the display of masked and
unmasked arrays.
This update addresses the issue by:
– Utilizing np.array2string to format the underlying data, ensuring
consistency with global print settings.
– Replacing masked elements with the masked_print_option string
('--' by default) while preserving formatting for visible elements.
– Maintaining support for legacy formatting options, including
truncation with ellipsis (...) when legacy='1.13' is set.
(Fixes numpy#28685)
28dbacd to
fc8a979
Compare
|
The pipeline tests that failed pass locally. I didn't change anything related to those tests (I think). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the string representation of masked arrays did not honor global print options such as floatmode, precision, and suppress. This led to inconsistencies between the display of masked and unmasked arrays.
This update addresses the issue by:
Maybe a bit overkill :)