Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

charris
Copy link
Member

@charris charris commented Apr 18, 2025

Partial backport of #28747.

  • reject boolean array indices
  • reject order: str | Sequence[str] unless it's a void array
  • reject passing self as keyword argument on classmethod calls

@charris charris added 08 - Backport Used to tag backport PRs 41 - Static typing labels Apr 18, 2025
@charris charris added this to the 2.2.5 release milestone Apr 18, 2025
@@ -16,7 +16,6 @@ from typing_extensions import Never, deprecated

import numpy as np
from numpy import (
number,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, this one also needs to stay apparently

@jorenham
Copy link
Member

Locally mypy passes when I apply those two changes.

@charris charris merged commit c200e8c into numpy:maintenance/2.2.x Apr 18, 2025
69 checks passed
@charris charris deleted the backport-28747 branch April 18, 2025 13:05
@jorenham
Copy link
Member

Thanks Chuck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 - Backport Used to tag backport PRs 41 - Static typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants