BUG: Fix #28730 histogram error with nan objects #28781
Open
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in histogram if the dtype of "a" (array like) was an object and contains nans.
|
This needs tests. Given that CI passed that indicates that our test coverage for this case is bad. Please add a test that would fail on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BUG: Fix #28730 histogram error when input has object dtype with NaNsThis Fixes a bug in np.histogram where object-dtyped arrays containing np.nan would cause a wrong output. Now such object arrays are cast to float before processing, fixing the bug.
Example
Before fix:
Output:
[1 1 0 1]
[1 1 0 0]
Returned incorrect bins because of improper handling of np.nan in object-dtype arrays
After fix:
Output:
[1 1 0 0]
[1 1 0 0]
Closes: #28730