MAINT: from_dlpack thread safety fixes #28883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
approved these changes
May 1, 2025
|
Thanks Nathan, save to backport, not sure if we want to. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
May 2, 2025
Fixes numpy#28881 Moves the global variables defined in from_dlpack to the npy_static_pydata struct and initializes them during module init.
charris
added a commit
that referenced
this pull request
May 2, 2025
MAINT: from_dlpack thread safety fixes (#28883)
MaanasArora
pushed a commit
to MaanasArora/numpy
that referenced
this pull request
May 8, 2025
Fixes numpy#28881 Moves the global variables defined in from_dlpack to the npy_static_pydata struct and initializes them during module init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28881
Moves the global variables defined in
from_dlpackto thenpy_static_pydatastruct and initializes them during module init.