BUG: Fix fftn failure when both out and s parameters are given #28895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a pypy issue. Similar to #28469 what they encountered. |
vtavana
reviewed
May 6, 2025
| if out is not None and s is not None and any(s[i] != a.shape[axes[i]] for i in range(len(axes))): | ||
| intermediate_out = None | ||
| else: | ||
| intermediate_out = out |
There was a problem hiding this comment.
Does it bring any performance improvement if we pass a itself when possible as out in intermediate steps (when out is originally None)? We might not be able to do so in the first iteration tough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28890
Problem
When N-dim FFTs are calculated using
fftn, the code performs a loop over all axes, applying 1D FFts in sequence. However, when bothoutandsare specified, intermediate transforms change the array shape, making theoutparameter incompatible with these intermediate results.Solution
This pr changes the
_raw_fftndto only use theoutparameter for the final transformation, not for intermediate steps. The current function works correctly when bothoutandshave different shapes than the input array.Test
The added test case verifies the fix with an input array of shape
(4, 4, 4)and an output with shape(6, 6, 6)