Backport2886and7#2900
Merged
Merged
Conversation
During a cleanup, the fast paths were invalidated because SIZEOF_LONGDOUBLE was not defined anymore and needs to be replaced with NPY_SIZEOF_LONGDOUBLE. The other SIZEOF macros still existed however so only complex long double broke because it switched to the already broken fast path. This commit fixes the fast path, and replaces all SIZEOF_ macros within arraytypes.c.src with their corresponding NPY_SIZEOF_ macros.
The sources don't define NPY_NO_PREFIX and consequently none of the unprefixed macros are defined. Using them can lead to some unexpected results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #2886 and #2887 into 1.7. Fixes #2889.