BUG: f2py: thread-safe forcomb #29091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure seems unrelated: |
|
(I restarted the failing CI too) |
|
I'll merge it, thanks. It LGTM and then it'll be in the next nightly wheel. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
May 31, 2025
charris
added a commit
that referenced
this pull request
May 31, 2025
BUG: f2py: thread-safe forcomb (#29091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29086
There are zero tests for this (you could add a syntax error and the numpy test suite would still pass).
With my complete lack of knowledge of fortran, I'm unable to write one.
Tested in scipy: scipy/scipy#23084