STY: ruff/isort config tweaks - episode 2 #29185
Open
+352
−601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like a lot of these changes. I'm also growing fond of the one line/item style, it is easy to read even though it takes more space, maybe even some of the one line multiple imports would benefit from that. |
Do you mean something like: from .utils import (
test_directory as test_directory,
test_id as test_id
)Because if so, we could enable Or are you talking about |
|
Yep, something like that. But I would hesitate to force that until there is a consensus. That said, it would probably be an easy follow on to this if we decide to go that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #29183. It's a separate PR, because not everyone might like these two config options.
I feel like
combine-as-importsrule is a rather natural rule, but that's probably just a personal preference thing.The
split-on-trailing-commarule, on the other hand, is rather unforgiving. It can reduce diffs, but it takes away the freedom of choosing to vertically align your imports. However, if you really want to do so anyway, then there's always the option of throwing a# noqa: I001at it.(and don't worry, I'm not planning on making this a trilogy)