BUG: fix matmul with transposed out arg (#29179) #29191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BUG: fix matmul with transposed out arg * DOC: add release note * fixes from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #29179.
Fixes #29164, the fix was suggested by @seberg
From the last comment in the issue:
I think that input is well tested via
numpy/_core/tests/test_multiarray.py::TestMatmul'stest_dot_equivalent, and there are some tests intest_out_contiguousbut that the specific case we hit here is missing. I added it: the test crashes before the fix, and passes after.BUG: fix matmul with transposed out arg
DOC: add release note
fixes from review