BUG: Fix NEON_FP16 check for MSVC #29199
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cast in `numpy/distutils/checks/cpu_neon_fp16.c` didn't compile correctly in MSVC, which lead to `NEON` reporting as unsupported due to it encompassing `NEON_FP16` in `meson_cpu/arm/meson.build`. I'm not an expert, but it appears `fp16`/`fp16fml`/`dotprod` are not supported in VS2022: https://learn.microsoft.com/en-us/cpp/build/reference/feature-arm64?view=msvc-170 Similarly, I don't think MSVC supports `float16` as a type yet, so I've enabled emulation in the strided loop code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cast in
numpy/distutils/checks/cpu_neon_fp16.cdidn't compile correctly in MSVC, which lead toNEONreporting as unsupported due to it encompassingNEON_FP16inmeson_cpu/arm/meson.build.I'm not an expert, but it appears
fp16/fp16fml/dotprodare not supported in VS2022: https://learn.microsoft.com/en-us/cpp/build/reference/feature-arm64?view=msvc-170Similarly, I don't think MSVC supports
float16as a type yet, so I've enabled emulation in the strided loop code.