CI: Add support for building NumPy with LLVM for Win-ARM64 #29215
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new CI environment to support building NumPy for Win-ARM64 using the LLVM toolchain. It introduces a new job in windows.yml for ARM64 builds, updates wheels.yml to use the new LLVM setup, and provides an action in windows_arm64_steps for installing LLVM.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/windows.yml | Added a new ARM64 build job and steps for both MSVC and Clang-cl configurations |
| .github/workflows/wheels.yml | Updated the ARM64 setup step to use the new LLVM action |
| .github/windows_arm64_steps/action.yml | Introduces a composite action to install LLVM for Win-ARM64 builds |
|
@rgommers can I trigger the wheel build on this PR? I forgot the incantation. |
You can by pushing a commit with |
|
@rgommers Please let me know if there are any changes needs to be applied in this patch |
There was a problem hiding this comment.
@Mugundanmcw can you make the hash check change that Copilot suggested, I'm less worried about the reformatting.
Otherwise https://github.com/Mousius/numpy/actions/runs/15731514222/job/44333523611 looks good to me, tests passing etc.
|
Thanks! Adding the backport label, I think that's warranted both because of the performance improvement and because we'd be getting signal much faster from 2.3.1 than from 2.4.0 in case anything is wrong. Cc @charris |
Reference issue
Closes: #29174
What does this implement/fix?
Enables new CI environment for building & validating NumPy for Win-ARM64 using LLVM toolchain.
Additional information