ENH: Detect CPU features on FreeBSD / OpenBSD RISC-V64. #29224
Merged
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Jun 18, 2025
| @@ -857,8 +857,14 @@ static void | |||
| npy__cpu_init_features(void) | |||
| { | |||
| memset(npy__cpu_have, 0, sizeof(npy__cpu_have[0]) * NPY_CPU_FEATURE_MAX); | |||
|
|
|||
| #if defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__) | |||
There was a problem hiding this comment.
This changes the logic and doesn't just extend it. Why not
#if defined(__FreeBSD__) || defined(__OpenBSD__)
,,,
#else
...
#endif
There was a problem hiding this comment.
Yes, just as the ARM / PowerPC code does the exact same thing. The current code is Linux specific and does not build.
bf0ba13 to
975833e
Compare
975833e to
5cbc0bc
Compare
|
Thanks @brad0 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.