TST: Fix test that uses uninitialized memory #29232
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests should avoid this generally, this one is worse, since it can even fail due to warnings.
0c3a70e to
7769009
Compare
|
Nice. Is this from valgrind? |
|
Unfortunately not, although valgrind would have shown it. My other PR actually failed tests on this. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jun 19, 2025
Tests should avoid this generally, this one is worse, since it can even fail due to warnings.
charris
added a commit
that referenced
this pull request
Jun 19, 2025
TST: Fix test that uses unininitialized memory (#29232)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests should avoid this generally, this one is worse, since it can even fail due to warnings.