You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But unfortunately this does help increase the "type completeness score". Running pyright --ignoreexternal --verifytypes numpy (after pip install .) shows the following:
before:
Symbols exported by "numpy": 9899
With known type: 4446
With ambiguous type: 485
With unknown type: 4968
(Ignoring unknown types imported from other packages)
Other symbols referenced but not exported by "numpy": 1658
With known type: 1592
With ambiguous type: 1
With unknown type: 65
Symbols without documentation:
Functions without docstring: 4625
Functions without default param: 353
Classes without docstring: 966
Type completeness score: 44.9%
Completed in 4.313sec
after:
Symbols exported by "numpy": 9841
With known type: 4412
With ambiguous type: 480
With unknown type: 4949
(Ignoring unknown types imported from other packages)
Other symbols referenced but not exported by "numpy": 1642
With known type: 1568
With ambiguous type: 2
With unknown type: 72
Symbols without documentation:
Functions without docstring: 4615
Functions without default param: 353
Classes without docstring: 962
Type completeness score: 44.8%
Completed in 4.267sec
So I suppose that the main advantage is that tests is no longer directly importable
Note that this does not remove _pyinstaller/tests/__init__.py and distutils/tests/__init__.py.
I guess this is for testing purposes only, but in case, are you sure removing the __init__.py is an advantage? In astropy at least, I've at times had sessions where it was helpful to just import a test class/function and run them (with parametrized tests, it allows trying different values). Obviously, not a huge deal, but maybe a reason to just leave things as they are.
p.s. I'm also surprised at the renaming - why rename test_regression.py to include the module name? The advantage of namespaces is that one doesn't have to!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x-ref: microsoft/pyright#10614 (reply in thread)
But unfortunately this does help increase the "type completeness score". Running
pyright --ignoreexternal --verifytypes numpy(afterpip install .) shows the following:before:
after:
So I suppose that the main advantage is that
testsis no longer directly importableNote that this does not remove
_pyinstaller/tests/__init__.pyanddistutils/tests/__init__.py.