BLD: allow targeting webassembly without emscripten #29447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #29436.
#28769 introduced the usage of the
clang fp exceptions(strict)pragma. However, this is broken when compiling for WebAssembly.For that reason, the pragma is omitted when targeting Emscripten (by checking for
__EMSCRIPTEN__). However, Clang can compile to WebAssembly without Emscripten. By also including a check for__wasm__, this patch allows NumPy to detect WebAssembly targets compiled without Emscripten.This broadens NumPy's compatibility with WebAssembly toolchains and environments other than emscripten, such as WASIX.
This PR is a follow-up to #29053, which also added
__wasm__to a check that was previously Emscripten-only. When compiling for WASIX, we didn't encounter this issue previously, as we were targeting an older NumPy version.