TST: Fix np.random thread test failures #29729
Conversation
There was a problem hiding this comment.
A couple of minor things. Other than that, the changes look good.
AFAICT, all of the tests in test_random.py could be converted to use explicit RandomState instances; I don't think they test anything about the np.random.* global method aliases separately. The only test in test_regression.py that actually tests global state functionality specifically is test_call_within_randomstate (it checks whether a specific RandomState method call on a separate instance might affect the global state). The rest are safe to convert. I think many of the test_random.py tests are duplicated by test_randomstate.py, but I don't think we need a separate copy that tests the np.random.* aliases explicitly, at least not in terms of their detailed functionality. IMO, at least.
|
@rkern Thank you for the feedback! I went ahead and committed the changes you suggested, as well as making changes to |
This PR is related to #29552, specifically seeking to address
np.randomthread safe issues. Calls to legacynp.randomaffects global state, and occasionally this results in test failures when running tests in parallel threads, especially when tests are expecting specific results for a specific seed (np.random.seedis a good indicator of this). This can be fixed by making these global state calls into local state calls usingGeneratororRandomStateinstances.For now, most of these tests have been converted to use
np.random.RandomStateinstances, since these test files are generally testing the legacy RandomState. Notablynumpy/random/test/test_random.pyandnumpy/random/test/test_regression.pyhave not been touched since I figured they should continue to test the globalnp.randomcalls and not be run in parallel. If folks think it's okay to also convert these files, I can definitely do so.