-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
DOC: Improve math format in accumulate #29742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
How about something like this? |
@jorenham Thank you for the suggestion! I have made the changes, and hope this works! |
Close/reopen to retry failed CI setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your original motivation was to simply move the i[0]
inwards a bit on the first line. Maybe for a first PR that is all you should try to do, and not change other things.
I see @jorenham's suggestion above also mixes subscripting and bracket-indexing. Sorry to step on his toes. |
I figured that since it's a mathematical formulation, then the |
Pseudocode is probably a better fit indeed. The formulations here do not accurately reflect the true C code, which uses |
Improve math format in accumulate
https://numpy.org/devdocs/dev/internals.code-explanations.html
Closed #29696 and reopened a new PR.